Feature/theme oled high contrast - #1256
Merged
ayomideadeniran merged 2 commits intoSep 3, 2026
Merged
Conversation
|
@martinshub-tech is attempting to deploy a commit to the Ayomide Adeniran's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@martinshub-tech Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
|
@martinshub-tech PR under review — I will get back to you if I find any wrong implementations. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1090
What was accomplished
Zero Runtime CSS-in-JS: Fully transitioned the theme configurations in frontend/src/app/globals.css using :root, .dark, and .oled scopes for pure CSS token architecture.
Flicker-Free Theme Init & FOUC Prevention: Refactored layout.tsx and providers.tsx to completely remove the anti-pattern manual script injection. next-themes now handles correct SSR injection of the natively before first paint, preventing any layout shift or flashing.
OLED High-Contrast WCAG AAA: Implemented the OLED theme mapping explicitly with pure #000000 backgrounds. Contrast colors like text (#ffffff), muted text (#cccccc), and borders (#555555) have been verified to exceed the strict 7:1 contrast ratio required for WCAG AAA compliance.
Simultaneous Monaco Update: Integrated the useThemeMode hook dynamically into CodeEditor.tsx so the Monaco Editor automatically and instantly syncs with your theme selection. OLED mode triggers Monaco's native hc-black high-contrast theme.
Universal Component Update: ThemeToggle.tsx now correctly cycles through all 3 modes and propagates the exact color hexes simultaneously to Charts via themeColors.ts.